Re: [LTP] [PATCH] fs/ext4-new-features: add ext4-new-features tests to the default

[<ch...@su...>]

Hi!
> >  include $(top_srcdir)/include/mk/generic_trunk_target.mk
> > diff --git a/testcases/kernel/fs/ext4-new-features/Makefile b/testcases/kernel/fs/ext4-new-features/Makefile
> > index 208b8a6..1ad1c3c 100644
> > --- a/testcases/kernel/fs/ext4-new-features/Makefile
> > +++ b/testcases/kernel/fs/ext4-new-features/Makefile
> > @@ -32,6 +32,7 @@ FILTER_OUT_DIRS		:= $(FFSBDIR)
> >  FFSB			:= $(FFSBDIR)/ffsb
> >  
> >  $(FFSB): $(FFSBDIR)
> > +	cd $^; ./configure
> >  	$(MAKE) -C $^ -f "$(abs_srcdir)/$^/Makefile" all
> >  	cp $(FFSBDIR)/ffsb ffsb
> 
> The way how ffsb is bundled in LTP is simply wrong, it shouldn't be in
> the source tree at all. What I would like to see is to:
> 
> 1. modify testcases that depends on it to return TCONF with
>    message that explains that ffsb must be installed to run
>    the testcases if ffsb is not found in PATH
> 
>    or alternatively use something different to create the
>    I/O load
> 
> 2. remove ffsb from the LTP git tree

Or at least the source tree should be moved to a proper place, there is
utils/benchmar/ directory for this purpose allready.

-- 
Cyril Hrubis
ch...@su...