Re: [LTP] [PATCH V2] rpc01: fix $TCbin and $TCtmp and data file names

[<ch...@su...>]

Hi!
> >> The values of TCbin and TCtmp should be swapped, and `rpc1' is in TCbin,
> >> not TCtmp.  Also correct the file names 'file.1' and 'file.2' which do not
> >> exist.
> >>
> >> Signed-off-by: Simon Xu <xu....@or...>
> >> ---
> >>   testcases/network/rpc/basic_tests/rpc01/rpc01 | 8 ++++----
> >>   1 file changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/testcases/network/rpc/basic_tests/rpc01/rpc01 b/testcases/network/rpc/basic_tests/rpc01/rpc01
> >> index ef97a95..8594835 100755
> >> --- a/testcases/network/rpc/basic_tests/rpc01/rpc01
> >> +++ b/testcases/network/rpc/basic_tests/rpc01/rpc01
> >> @@ -36,13 +36,13 @@
> >>   $trace_logic
> >>   this_file=${0##*/}
> >>   TC=${TC:=rpc01}
> >> -TCbin=${TCbin:=`pwd`}
> >> +TCbin=${TCbin:=$LTPROOT/testcases/bin}
> >>   TCdat=${TCdat:=$TCbin/datafiles}
> >> -TCtmp=${TCtmp:=$LTPROOT/testcases/bin}
> >> +TCtmp=${TCtmp:=`pwd`}
> >>   NUMLOOPS=${NUMLOOPS:=3}
> >>   RHOST=${RHOST:=`hostname`}
> >>   CLEANUP=${CLEANUP:="ON"}
> >> -DATAFILES=${DATAFILES:="file.1 file.2"}
> >> +DATAFILES=${DATAFILES:="bin.med bin.sm"}
> >>   
> >>   #=============================================================================
> >>   # FUNCTION NAME:        do_test
> >> @@ -68,7 +68,7 @@ do_test()
> >>       do
> >>         for FILE in $DATAFILES
> >>         do
> >> -	$TCtmp/rpc1 -s $RHOST -f $TCdat/$FILE
> >> +	$TCbin/rpc1 -s $RHOST -f $TCdat/$FILE
> > The runltp script adds $LTPROOT/testcases/bin to path so you should
> > reduce this only to rpc1 and it should work.
> >
> > The runltp script also sets $TMPDIR as temporary directory.
> 
> Yes this fix is only for rpc01.  And it seems that rpc01 is not designed 
> for runltp script, but for networktests.sh, which uses TCtmp and TCbin.

The test rpc01 is listed in runtest/rpc and runtest/stress.part3 files, i.e. it
is possible to execute these tests by runltp script.

Moreover all the tests in LTP should follow the same arangement of temp
directory, test binaries directory, etc.

-- 
Cyril Hrubis
ch...@su...