Re: [LTP] [PATCH] syscalls/setgroups: fix implicit SETGROUPS parameter casting

[Stanislav K. <sta...@or...>]

On 08/26/2013 06:16 PM, ch...@su... wrote:
> Hi!
>> But we can't rely on the fact that group ids of a user invoking the
>> testcases are fit into __old_gid_t.
>>
>> And the purpose of current GETGROUPS definition is to handle such cases.
>>
>> A situation may happen where root user is a member of a group with a
>> _big_ group id.
>>
>> So I'm not 100% sure about fixing getgroups part of the same header.
>>
>> Or did I miss something?
> What I mean is that we should check if the compatibility getgroups
> syscall exists and if not abort the test (as the setgroups will do).
I understand, but should it be a part of syscalls/setgroups testcases?

Maybe we should modify a little bit syscalls/getgroups tests and add 
this check there?

> Because the 32 bit getgroups syscall is tested with the tests without
> the TST_USE_COMPAT16_SYSCALL.