Re: [LTP] [PATCH 1/2 v3] xinetd/xinetd_tests.sh: cleanup tabs

[Hangbin L. <liu...@gm...>]

On Thu, Jul 11, 2013 at 01:28:34AM +0800, Caspar Zhang wrote:
> On 07/10/2013 07:03 PM, Xie Lingyun wrote:
> >+defaults
> >+{
> >+instances      = 25
> >+log_type       = FILE /var/log/servicelog
> >+log_on_success = HOST PID
> >+log_on_failure = HOST RECORD
> >+disabled       = telnet
> >+}
> 
> Generally looks good except here.
> 
> better give a 4-space indentation inside the braces.
> 

1-tab or 4-space, I always be confuse which should we use. Even a tab should
be 4 characters or 8 characters also have dispute. But the kernel coding style
said Tabs are 8 characters, and thus indentations are also 8 characters.

So, should we also use this style in shell scripts? Because I'm tired
changing my vim config for each project.
-- 

Thanks & Best Regards
Hangbin Liu <liu...@gm...>