From: Sedat D. <sed...@gm...> - 2013-06-27 13:16:59
|
On Thu, Jun 27, 2013 at 3:02 PM, Carlos Hernandez <ce...@ti...> wrote: > On 06/27/2013 08:42 AM, Sedat Dilek wrote: >> >> Add IPC syscalls test-cases from "runtest/syscalls" file also to >> "runtest/ipc" for people interested in running IPC tests only. >> >> Run via './runltp -f ipc'. >> >> Signed-off-by: Sedat Dilek<sed...@gm...> >> --- >> runtest/ipc | 60 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 60 insertions(+) > > > NAK. Duplication is generally a bad idea. > This have the side effect of running the same tests twice for people that > run ipc and syscalls test scenarios. > The background of this was an issue in Linux-Next. The ipc test-cases were fine, but syscalls test-cases revealed that sth. was wrong in that Linux-Next release. For me it was not clear to also test the syscalls. So, what is with the idea of a "runtest/syscalls-ipc" file (my original "v1" patch, this here is "v2")? Please, think also of the long duration of syscalls tests! - Sedat - |