Re: [LTP] [PATCH] tst_module: create new library functions for kernel modules

[Mike F. <va...@ge...>]

On Monday 24 June 2013 07:56:35 ch...@su... wrote:
> > > +/* declared in tst_tmpdir.c */
> > > +const char *tst_get_startwd(void);
> > 
> > use a proper header instead.  extern func decls only leads to bit rot and
> > hard to debug crashes.
> 
> This is internal only API for the LTP lib that does not have a proper
> header (I was too lazy to create a header for the function that is used
> only once). I can fix that if desired.

if it's meant as an internal-to-the-lib func, then we should start a header to 
hold that kind of code.  we can easily enforce it too by having the lib 
Makefile define some macro that the header will check and error out if it isn't 
present.
-mike