Re: [LTP] syscalls/mount0* and inotify03 tests are getting skipped from runltp

[Ramesh <ram...@li...>]

On 03/27/2013 01:17 AM, ch...@su... wrote:
> Hi!
>> I tried to run syscalls test with ./runltp -f syscalls, it's found that
>> the below tests
>> are getting skipped from the run,
>> -----------
>> inotify03 inotify03 -D DEVICE -T DEVICE_FS_TYPE
>> mount01 mount01 -D DEVICE -T DEVICE_FS_TYPE
>> mount02 mount02 -D DEVICE -T DEVICE_FS_TYPE
>> mount03 mount03 -D DEVICE -T DEVICE_FS_TYPE
>> mount04 mount04 -D DEVICE -T DEVICE_FS_TYPE
>> umount01 umount01 -D DEVICE -T DEVICE_FS_TYPE
>> umount02 umount02 -D DEVICE -T DEVICE_FS_TYPE
>> umount03 umount03 -D DEVICE -T DEVICE_FS_TYPE
>> -----------
>>
>> I didn't get the value of DEVICE&  DEVICE_FS_TYPE in any of conf files
>> and also, as
>> the tests expect a block device, I executed the tests by specifying a
>> block device
>> (-D /dev/sda1 -T ext4), tests passed.
>>
>> Also,as the DEVICE&  DEVICE_FS_TYPE need to be explicitly specifed to
>> all the tests,
>> these tests should be commented out in ltp/runtest/syscalls which is
>> used by runltp.
>>
>> Any comments on this issue are appreciated.
> The runtest files are processed before they are executed. See -b DEVICE and
> -B DEVICE_FS_TYPE runltp parameters.
>
> The current runltp script is more of the hack than solution. I've send a
> RFC email with a description of planned successor to the LTP mailing
> list not that long ago (but I haven't started writing the code yet).

Thanks Cyril !

I got it from runltp --usage, then I tried to execute the tests by passing
-b DEVICE and -B DEVICE_FS_TYPE to runltp but it failed with the below 
error,

---
sed: can't read : No such file or directory
FATAL: error during processing alltests file by sed
---

I went through the runltp script to see the cause for this error and 
found that
the below substitution by sed leading to the error.

 >> sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|"  ${TMP}/alltests

Here, I don't see any reason why the -e is used with sed as we are not 
performing
sed operation on multiple expressions.

I just removed -e option and ran the tests, tests were successfully 
executed.

<patch snippet>
--- runltp_org    2013-03-27 14:40:12.029836439 +0530
+++ runltp    2013-03-27 14:39:59.322856566 +0530
@@ -719,7 +719,7 @@ main()
      fi

      if [ -n "$DEVICE" ]; then
-        sed -i "" -e "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|"  ${TMP}/alltests
+        sed -i "s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|"  ${TMP}/alltests
      fi

      if [ $? -ne 0 ]; then



Please le me know if the removal of -e is a better solution for the 
issue or is it really
required for any other advantages.



Regards,
Ramesh YR