Re: [LTP] [PATCH v4] syscalls/getdents: Add parameter to test getdents64 syscall

[<ch...@su...>]

Hi!
> >> > > You don't need to bother to free the buffers when the next thing
> >> > > the
> >> > > test does is exit, the whole heap along with malloc data
> >> > > structures
> >> > > will
> >> > > be freed (unmapped) by the kernel anyway.
> >> >
> >> > I think it's nice thing to cleanup. Say, if test corrupted heap,
> >> > free could alert you. Also there are tools, which may complain,
> >> > that there's a leak now. I think LTP supports at least valgrind.
> >>
> >> So what about compromise, defining them as variables instead of the
> >> allocation?
> >
> > That would work. You really want that free() gone, don't you? :-).
> >
> 
> Yeah I was about to ask the same thing. I see no problem with keeping free()
> around and I don't think there is an urgent need to convert these
> pointers to variables.

I've changed them to be variables and the getdents64 now seems to
segfault randomly. I will look closely at the code, my guess is that
the size of the structure is counted/propagated wrongly somewhere.

-- 
Cyril Hrubis
ch...@su...