Re: [LTP] [PATCH v4] syscalls/getdents: Add parameter to test getdents64 syscall

[<ch...@su...>]

Hi!
> > > > You don't need to bother to free the buffers when the next thing
> > > > the
> > > > test does is exit, the whole heap along with malloc data
> > > > structures
> > > > will
> > > > be freed (unmapped) by the kernel anyway.
> > > 
> > > I think it's nice thing to cleanup. Say, if test corrupted heap,
> > > free could alert you. Also there are tools, which may complain,
> > > that there's a leak now. I think LTP supports at least valgrind.
> > 
> > So what about compromise, defining them as variables instead of the
> > allocation?
> 
> That would work. You really want that free() gone, don't you? :-).

I hate when there is unnecessary complexity in the tests that is not
really needed for the testing itself...

-- 
Cyril Hrubis
ch...@su...