Re: [LTP] [PATCH v4] syscalls/getdents: Add parameter to test getdents64 syscall

[Markos C. <mar...@gm...>]

On 18 March 2013 13:46, Jan Stancek <jst...@re...> wrote:
>
>
> ----- Original Message -----
>> From: ch...@su...
>> To: "Jan Stancek" <jst...@re...>
>> Cc: ltp...@li..., "Markos Chandras" <mar...@gm...>
>> Sent: Monday, 18 March, 2013 2:26:27 PM
>> Subject: Re: [LTP] [PATCH v4] syscalls/getdents: Add parameter to test getdents64 syscall
>>
>> Hi!
>> > > You don't need to bother to free the buffers when the next thing
>> > > the
>> > > test does is exit, the whole heap along with malloc data
>> > > structures
>> > > will
>> > > be freed (unmapped) by the kernel anyway.
>> >
>> > I think it's nice thing to cleanup. Say, if test corrupted heap,
>> > free could alert you. Also there are tools, which may complain,
>> > that there's a leak now. I think LTP supports at least valgrind.
>>
>> So what about compromise, defining them as variables instead of the
>> allocation?
>
> That would work. You really want that free() gone, don't you? :-).
>

Yeah I was about to ask the same thing. I see no problem with keeping free()
around and I don't think there is an urgent need to convert these
pointers to variables.

-- 
Regards,
Markos Chandras