Re: [LTP] [PATCH v2] syscalls/getdents: Add parameter to test getdents64 syscall

[Markos C. <mar...@gm...>]

On 16 March 2013 15:48, Mike Frysinger <va...@ge...> wrote:
> On Friday 15 March 2013 09:49:30 Markos Chandras wrote:
>> Add new "-l" parameter to test the getdents64 syscall along with
>> the getdents one. Use ltp_syscall() to call the system call to get
>> proper return values when an architecture does not support any of the
>> getdents{,64} syscalls. Modify runtest/syscalls to call getdentsXX tests
>> with and without the "-l" parameter
>
> your patch introduces a lot of warnings.  please verify it on a few arches
> first (like x86_64).

Yes I see what you mean. I will prepare a new one.

>
>> --- a/testcases/kernel/syscalls/getdents/Makefile
>> +++ b/testcases/kernel/syscalls/getdents/Makefile
>>
>> +CFLAGS += -D_LARGEFILE64_SOURCE
>
> these are CPPFLAGS, not CFLAGS
> -mike

Indeed. I will fix it too.

-- 
Regards,
Markos Chandras