From: <ch...@su...> - 2012-12-06 14:24:38
|
Hi! > > + 84?? .??cmdlib.sh > > Patch series looks good to me except this. The patch series looks really good. > sourcing a lib inside a function seems not so good. Yet I don't see any > code style rules telling which is the correct place to put a shell lib > source (commonly I think it would be the top in the file) It's always better to include the bash library first so that your variables are not rewritten by these used in the library. I've seen cases where this was a issue (one test included a file from init scripts which is different in diferent version of distribution and in one case the name clashed) and the test was broken because the file wasn't included at the top. So actually this is not hard requirement but rather a good practice. -- Cyril Hrubis ch...@su... |