Re: [LTP] [PATCH 0/2] move_pages: dont use hardcoded node numbers

[Caspar Z. <cz...@re...>]

On 05/25/2012 05:33 PM, Jan Stancek wrote:
> 
> 
> ----- Original Message -----
>> From: "Caspar Zhang" <ca...@ca...>
>> To: ltp...@li...
>> Sent: Friday, 25 May, 2012 11:16:09 AM
>> Subject: Re: [LTP] [PATCH 0/2] move_pages: dont use hardcoded node numbers
>>
>>> Jan Stancek (2):
>>>   move_pages_support: use only allowed nodes
>>>   move_pages: dont use hardcoded node numbers
>>>
>>>  .../kernel/syscalls/move_pages/move_pages02.c      |   13 +++-
>>>  .../kernel/syscalls/move_pages/move_pages03.c      |   13 +++-
>>>  .../kernel/syscalls/move_pages/move_pages04.c      |   13 +++-
>>>  .../kernel/syscalls/move_pages/move_pages05.c      |   13 +++-
>>>  .../kernel/syscalls/move_pages/move_pages06.c      |   10 ++-
>>>  .../kernel/syscalls/move_pages/move_pages07.c      |   13 +++-
>>>  .../kernel/syscalls/move_pages/move_pages08.c      |   12 +++-
>>>  .../kernel/syscalls/move_pages/move_pages09.c      |    8 ++-
>>>  .../kernel/syscalls/move_pages/move_pages10.c      |   13 +++-
>>>  .../kernel/syscalls/move_pages/move_pages11.c      |   13 +++-
>>>  .../syscalls/move_pages/move_pages_support.c       |   74
>>>  ++++++++++++++++----
>>>  .../syscalls/move_pages/move_pages_support.h       |    1 +
>>>  12 files changed, 157 insertions(+), 39 deletions(-)
>>>
>>
>> Looks like many duplications here... wondering if any chance putting
>> them into a common function or something?
>>
> 
> That is probably good idea, because we may still find new places where can use it.
> I'm thinking about something like numa_helper.a, which we could link with

I have no objection doing that.

Cyril, suggestions?

Caspar

> mbind01, get_mempolicy01, move_pages, etc.
> 
> Or can you think of any better place where to put it?
> 
> Regards,
> Jan