Re: [LTP] [PATCH] Add a functional test for the IN_DELETE_SELF event

[Garrett C. <yan...@gm...>]

On May 18, 2012, at 5:59 AM, Cyril Hrubis wrote:

> Hi!
>> +/****************************************************************************
>> + * NAME
>> + *     inotify04
>> + *
>> + * DESCRIPTION
>> + *     verify that IN_DELETE_SELF functions as expected
>> + *
>> + * ALGORITHM
>> + *     Create a temporary directory, then add watches to a predefined file and
>> + *     directory, and delete the file and directory to ensure that the
>> + *     IN_DELETE_SELF event is captured properly.
>> + *
>> + *     Because of how the inotify(7) API is designed, we also need to catch the
>> + *     IN_ATTRIB and IN_IGNORED events.
>> + *
>> + * HISTORY
>> + *
>> + * ***************************************************************************/
> 
> Looks good, but runtest entry is missing. And (as I said in different
> mail allready) I would remove the NAME and HISTORY from the comment
> above.

It's in the diff in my local tree. Basically:

diff --git a/runtest/syscalls b/runtest/syscalls
index 679ff5b..e203d5e 100644
--- a/runtest/syscalls
+++ b/runtest/syscalls
@@ -439,6 +439,7 @@ inotify_init1_02 inotify_init1_02
 inotify01 inotify01
 inotify02 inotify02
 inotify03 inotify03 -D DEVICE -T DEVICE_FS_TYPE
+inotify04 inotify04
 
 ioperm01 ioperm01
 ioperm02 ioperm02

I'll yank the other references.

I need to know if the inotify.h cleanup is ok before committing this.

Thanks!
-Garrett