Re: [LTP] [PATCH 1/2] Clean up inotify(7) wrappers

[Wanlong G. <gao...@cn...>]

On 04/11/2012 05:21 PM, Garrett Cooper wrote:

> On Apr 10, 2012, at 7:52 PM, Wanlong Gao <gao...@cn...> wrote:
> 
>> On 04/05/2012 09:52 AM, Mike Frysinger wrote:
>>
>>> On Wednesday 04 April 2012 20:38:31 Garrett Cooper wrote:
>>>> +/*
>>>> + * ``junk`` is needed to make the macro function like a void argument
>>>> + * function.
>>>> + */
>>>> +#define    myinotify_init(junk)    syscall(__NR_inotify_init)
>>>
>>> you lost me.  how does this make it work like a (void) func ?  i think this 
>>> should drop the "junk" and just do:
>>>    #define myinotify_init() ...
>>
>>
>> Cooper,
>>
>> Any update on what Mike said?
> 
> Simply put, his method is cleaner/better. I need to produce a new patch with his suggested change.


That's great!

Thanks,
Wanlong Gao

> 
> Thanks!
> -Garrett
>