Re: [LTP] [PATCH] mq_timedreceive: 10-2.c: check timeout error rather than invalid parameter error

[Peng H. <pe...@cn...>]

Akira Takeuchi said the following on 2012-3-22 12:23:
> 10-2.c now passes the invalid parameter to mq_timedreceive by specifying
> a negative value to nanoseconds field, and checks whether EINVAL is not
> returned when a message can be removed from the queue immediately.
> 
> However, this may not be a appropriate testing of mq_timedreceive.
> POSIX spec of mq_timedreceive says:
>     The validity of the abstime parameter need not be checked
>     if a message can be removed from the message queue immediately.
> 
> This is open for interpretation of POSIX spec, and it was argued about in LKML.
>     https://lkml.org/lkml/2012/3/14/589
> 
> The conclusion in LKML was that what POSIX spec says is "you don't *have*
> to check validity". That is, it is allowed to check the validity.
> 

Yeah.

> On the other hand, actually, timeout error should not be returned when message
> can be performed immediately.
> 

POSIX spec does not say this, so I think it is not necessary to check timeout error.

> Therefore, I modify the testcase to check timeout error rather than invalid
> parameter error.
> 
> Signed-off-by: Akira Takeuchi <tak...@jp...>
> Signed-off-by: Kiyoshi Owada <owa...@jp...>
> ---
>  .../conformance/interfaces/mq_timedreceive/10-2.c  |   20 +++++++++-----------
>  1 files changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/testcases/open_posix_testsuite/conformance/interfaces/mq_timedreceive/10-2.c b/testcases/open_posix_testsuite/conformance/interfaces/mq_timedreceive/10-2.c
> index 49ee4f2..1cbb5b6 100644
> --- a/testcases/open_posix_testsuite/conformance/interfaces/mq_timedreceive/10-2.c
> +++ b/testcases/open_posix_testsuite/conformance/interfaces/mq_timedreceive/10-2.c
> @@ -8,12 +8,11 @@
>  
>  /*
>   * If the message can be removed from the message queue immedietely,
> - * the operation will never fail and the validity of abs_timeout
> - * need not be checked.
> + * the operation will not fail even if abs_timeout is the past time.
>   * Test Steps:
> - * 1. Set the abs_timeout to be invalid, when there is message
> + * 1. Set the abs_timeout to be a past time, when there is message
>   *    than can be removed from the message queue immediately.
> - * 2. The validity of abs_timeout will not be checked.
> + * 2. Timeout error is not occured.
>   */
>  
>  #include <stdio.h>
> @@ -27,7 +26,7 @@
>  #include <errno.h>
>  #include "posixtest.h"
>  
> -#define TEST "10-1"
> +#define TEST "10-2"
>  #define FUNCTION "mq_timedreceive"
>  #define ERROR_PREFIX "unexpected error: " FUNCTION " " TEST ": "
>  
> @@ -61,12 +60,11 @@ int main()
>          }
>  
>  	sleep(1); /* wait for a while */
> -	ts.tv_sec = time(NULL) -1; /* No wait */
> -	ts.tv_nsec = -1; /* Invalid */
> +	ts.tv_sec = time(NULL) -1; /* Past time */
> +	ts.tv_nsec = 0;
>          if (mq_timedreceive(mqdes, msgrv, BUFFER, &rvprio, &ts) == -1) {
> -		if (errno == EINVAL)
> -			printf("FAIL: the validity of abs_timeout "
> -				"is checked\n");
> +		if (errno == ETIMEDOUT)
> +			printf("FAIL: mq_timedreceive returned timeout error\n");

The lines need not to be added.
timeout error can be as Unexpected error.

-- 
Best Regards,
Peng

>  		else
>  			perror("Unexpected error at mq_timedreceive");
>  		failure = 1;
> @@ -94,4 +92,4 @@ int main()
>  
>          printf("Test PASSED\n");
>          return PTS_PASS;
> -}
> \ No newline at end of file
> +}