Re: [LTP] [PATCH] mount1234: invert the logic in handling failures

[Carmelo A. <car...@st...>]

On 26/01/2012 16.12, Cyril Hrubis wrote:
> Hi!
>> mount is expected to fail if the device is a 'tty', so it seems that
>> the original idea of this testcase were to test mount failures.
>> If this is true, then the logic to handle the test results has to be inverted
>> and consider the test case as PASSED if mount fails, while FAILED
>> if mount erroneuosly succeeded to mount a tty device.
>>
>> It also fixes a syntax error in substring expansion ( ${parameter:offset} )
>>
>> The last check "mount04" has been removed as it does not cehck the device type
>> but only the permission so that it is incosistent with the overall logic.
>>
>> That said, rename the test case as mount123
> 
> Hmm, still the output of the testcases would say FAILED from the
> respective mount testcases and then PASSED from the test script. My
> guess is that this was some leftover testing script for testing the
> testcase failures. What about removing it entirely?
> 

Hi Cyril,
I understand our point. Removing it is fine to me too.

Carmelo