From: Garrett C. <yan...@gm...> - 2011-03-04 16:29:58
|
On Fri, Mar 4, 2011 at 8:09 AM, Cristian Greco <cri...@re...> wrote: > Hi, > > this should fix a regression in kill05. > > Why did tst_resm/tst_exit get replaced by perror/exit in 84f181fd? Because it's a child process and child processes should _not_ use libltp for sanity and to avoid introducing determinism, test bugs, and for cluttering up output (remember: you have to communicate to the user which process is actually doing the work, they're sharing file descriptors potentially, etc). The proposed fix doesn't make sense though because do_master_child always exits when the flow is executed correctly (i.e. there aren't any early return statements from do_master_child, etc. Is it not resuming the stack appropriately after it gets signaled? What's the call flow exactly for the failure? Thanks, -Garrett |