From: Caspar Z. <cz...@re...> - 2011-03-04 09:31:58
|
On 03/04/2011 05:27 PM, Garrett Cooper wrote: > On Fri, Mar 4, 2011 at 12:52 AM, Caspar Zhang <cz...@re...> wrote: >> On 03/04/2011 04:37 PM, Cristian Greco wrote: >>> wouldn't it be better to call tst_resm() with TCONF instead of TINFO, >>> for the sake of consistency? >> >> Agree. Updated to v3: >> >> These tests contain x86 asm so that they wouldn't be run on x86_64 >> machine, but run into a simple main() functions instead. However all of >> them are missing tst_exit() which could result in a exit_code=10 >> failure. > > Fixing it with equivalent: > > tst_brkm(TBROK, NULL, ...); TBROK returns a non-zero value, which may result in a FAIL in log... Caspar > > Thanks, > -Garrett -- Quality Engineer (Kernel) in Red Hat Software (Beijing) Co., R&D Branch http://www.cn.redhat.com/ TEL: +86-10-62608150 |