Re: [LTP] [PATCH] unshare01.c: TEST_RETURN is used wrong

[Garrett C. <yan...@gm...>]

On Tue, Feb 15, 2011 at 5:26 AM, Serge E. Hallyn
<ser...@ca...> wrote:
> Quoting Peng Haitao (pe...@cn...):
>> Hi Garrett,
>>
>> Signed-off-by: Peng Haitao <pe...@cn...>
>> ---
>>  testcases/kernel/syscalls/unshare/unshare01.c |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/testcases/kernel/syscalls/unshare/unshare01.c b/testcases/kernel/syscalls/unshare/unshare01.c
>> index e19d73d..9ae5e8f 100644
>> --- a/testcases/kernel/syscalls/unshare/unshare01.c
>> +++ b/testcases/kernel/syscalls/unshare/unshare01.c
>> @@ -206,7 +206,7 @@ int main(int ac, char **av) {
>>                       }
>>
>>                       pid1 = fork();
>> -                     if (TEST_RETURN == -1) {
>> +                     if (pid1 == -1) {
>
> Looking at the rest of that file, isn't the right fix to
> wrap 'pid1 = fork();' in a TEST() macro?

Hi Serge!
    I would agree with you, but in my firm opinion this testcase
abuses TEST_ERRNO, etc way too much for no good reason.
    I just didn't remember to follow through finishing off this file
for some odd reason.
Thanks,
-Garrett