Re: [LTP] [PATCH]Remove redundance code.

[Garrett C. <yan...@gm...>]

On Dec 30, 2010, at 1:17 AM, Cyril Hrubis wrote:

> Hi!
>> It's incorrect to close a file twice, so remove the redundance code.
>> 
>> Signed-off-by: Bian Naimeng <bi...@cn...>
> 
> Good catch ;).
> 
> It seems like this broke in Garrett's style commit.

Yeah... git's simple merge with the change and the human running the merge didn't catch the error.

> And there are more. The uid_t and gid_t is unsigned so (uid_t)-1 is the
> only way how to pass -1 to lchown() without warning. That's even said in
> POSIX documentation.

Ack. This is a bug in the POSIX spec from the looks of it. Both FreeBSD and Linux define {gid,uid}_t as uint32_t types. Will CC the austin group list once I figure out the proper wording for the issue.

> Garrett please remove the first one close() and add back the (uid_t) and
> (gid_t). Also the tst_brkm() messages in lchown01 got a little
> unconsistent after this merge.

Fixed the inconsistent messages.

Thanks,
-Garrett