Re: [LTP] [PATCH] mbind_range() vma merge

[CAI Q. <ca...@re...>]

> > +	/* message returned from parse_opts */
> > +	char *msg;
> > +
> 
> Well I think there is no need for that comment, everybody sees that
> this
> is a message returned from parse_opts.
OK.

> > +	/* loop counter */
> > +	int lc;
> 
> Same here, no need to say "this is a counter". Save comments for
> places
> where they are really needed.
OK.

> > +		if (addr == MAP_FAILED)
> > +			tst_brkm(TBROK|TERRNO, NULL, "mmap"), exit(1);
> 
> You should use tst_brkm(TBROK|TERRNO, tst_exit, "mmap") here. As
> tst_brkm() exits when pointer to cleanup is not NULL.
Yes, just figured that out.

CAI Qian