Re: [LTP] [PATCH] mmap/munmap /dev/zero

[CAI Q. <ca...@re...>]

----- "Garrett Cooper" <yan...@gm...> wrote:

> On Tue, Oct 12, 2010 at 12:15 PM, Mike Frysinger <va...@ge...>
> wrote:
> > On Tuesday, October 12, 2010 10:07:16 CAI Qian wrote:
> >> +/* main setup function of test */
> >> +void setup();
> >> +/* cleanup function for the test */
> >> +void cleanup();
> >> +int mmapzero();
> 
> ...
> 
>     +1 to what Mike said, but in all actually what is the purpose of
> this test? There isn't a description either in the commit message or
> the code itself that mentions what this code should functionally do.
> We need both in order for the code to be committed (otherwise folks
> will play the "WTF does this code do?" game when semantics change a
> few years later in the GNU/Linux world).
> Thanks,
Fixed in v2.
> -Garrett