Re: [LTP] [PATCH] timers: support clockid of CLOCK_REALTIME_COARSE/CLOCK_MONOTONIC_COARSE

[Garrett C. <yan...@gm...>]

On Thu, Feb 25, 2010 at 1:00 AM, Rishikesh K Rajak
<ris...@li...> wrote:
> On Wed, Feb 24, 2010 at 07:22:09PM -0800, Garrett Cooper wrote:
>>     I've added the autoconf-conditionalized variables along with your
>> changes, and some other minor cleanups to git just moments ago.
> Hi Garret,
>
> Getting the build error on today's tree as:
>
> gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall
> -I/root/temp/testcases/kernel/include -D_GNU_SOURCE
> -I/root/temp/testcases/kernel/timers/clock_gettime/../include
> -I../../../../include -I../../../../include   -L../../../../lib
> clock_gettime02.c   -lltp -lpthread -lrt -o clock_gettime02
> In file included from clock_gettime02.c:73:
> /root/temp/testcases/kernel/timers/clock_gettime/../include/common_timers.h:22:
> error: `CLOCK_MONOTONIC_RAW' undeclared here (not in a function)
> /root/temp/testcases/kernel/timers/clock_gettime/../include/common_timers.h:22:
> error: initializer element is not constant
> /root/temp/testcases/kernel/timers/clock_gettime/../include/common_timers.h:22:
> error: (near initialization for `clock_list[4]')
> make[4]: *** [clock_gettime02] Error 1
> make[4]: Leaving directory
> `/root/temp/testcases/kernel/timers/clock_gettime'
> make[3]: *** [all] Error 2
> make[3]: Leaving directory `/root/temp/testcases/kernel/timers'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/root/temp/testcases/kernel'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/root/temp/testcases'
> make: *** [testcases-all] Error 2
> [root@elm17d44 temp]# vim
> /root/temp/testcases/kernel/timers/clock_gettime/../include/common_timers.h
>
>
> And this patch solves the problem, please Ack it if it is correct
> solution, so that i can merge to tree.
>
>    Signed-off-by: Rishikesh K Rajak <ris...@li...>
>
> diff --git a/testcases/kernel/timers/include/common_timers.h
> b/testcases/kernel/timers/include/common_timers.h
> index cae9626..1e103b1 100644
> --- a/testcases/kernel/timers/include/common_timers.h
> +++ b/testcases/kernel/timers/include/common_timers.h
> @@ -19,7 +19,6 @@ clock_t clock_list[] = {
>        CLOCK_MONOTONIC,
>        CLOCK_PROCESS_CPUTIME_ID,
>        CLOCK_THREAD_CPUTIME_ID,
> -       CLOCK_MONOTONIC_RAW,
>  #if HAVE_CLOCK_REALTIME_COARSE
>        CLOCK_REALTIME_COARSE,
>  #endif
> @@ -40,7 +39,6 @@ const char *get_clock_str(const int clock_id)
>        CLOCK_TO_STR(CLOCK_MONOTONIC);
>        CLOCK_TO_STR(CLOCK_PROCESS_CPUTIME_ID);
>        CLOCK_TO_STR(CLOCK_THREAD_CPUTIME_ID);
> -       CLOCK_TO_STR(CLOCK_MONOTONIC_RAW);
>  #if HAVE_CLOCK_REALTIME_COARSE
>        CLOCK_TO_STR(CLOCK_REALTIME_COARSE);
>  #endif

    What version of Linux is this? I specifically took out the #ifndef
... #define ... #endif blocks because I'm trying to avoid these ad hoc
#define's scattered around the tree.
Thanks,
-Garrett