Re: [LTP] [PATCH] swapon03 cleanup

[Murlin W. <mw...@no...>]

>>> On 2/24/2010 at 03:33 PM, in message
<364...@ma...>, Garrett Cooper
<yan...@gm...> wrote: 
> On Wed, Feb 24, 2010 at 2:32 PM, Murlin Wenzel <mw...@no...> wrote:
>>>>> On 2/24/2010 at 03:22 PM, in message
>> <364...@ma...>, Garrett Cooper
>> <yan...@gm...> wrote:
>>> On Wed, Feb 24, 2010 at 1:44 PM, Murlin Wenzel <mw...@no...> wrote:
>>>>>>> On 2/24/2010 at 02:25 PM, in message
>>>> <364...@ma...>, Garrett Cooper
>>>> <yan...@gm...> wrote:
>>>>> On Wed, Feb 24, 2010 at 1:23 PM, Murlin Wenzel <mw...@no...> wrote:
>>>>>>>>> On 2/24/2010 at 02:16 PM, in message
>>>>>> <364...@ma...>, Garrett Cooper
>>>>>> <yan...@gm...> wrote:
>>>>>>> On Wed, Feb 24, 2010 at 9:43 AM, Murlin Wenzel <mw...@no...> wrote:
>>>>>>>> This cleans up existing swap files in swapon03 test in failing test case.
>>>>>>> Otherwise, deleted swap files would still exist in /proc/swaps.
>>>>>>>>
>>>>>>>> Signed-off-by: Murlin Ray Wenzel mw...@no...
>>>>>>>
>>>>>>> Why not implement this as part of cleanup?
>>>>>>> Thanks,
>>>>>>> -Garrett
>>>>>>
>>>>>> I can look at doing that.  I just grabbed the closest place that worked for
>>>>> me.  BTW I'm still looking at a possible kernel bug where you can't allocate
>>>>> the maximum number of swap files.
>>>>>
>>>>> What kernel version are you working with?
>>>>> -Garrett
>>>>
>>>> I'm testing on 2.6.32.7, but I've been told that the same problem doesn't
>>> happen on 2.6.33 and it shouldn't happen on some as yet unknown previous
>>> versions.
>>>
>>>     If they changed the maximum number of swap files, then this would
>>> be the cause for the problem as it's set to 30 since 2.6.18. See
>>> include/swaponoff.h .
>>> HTH,
>>> -Garrett
>>
>> The problem is MAX_SWAPFILES reports 30 but you only get 29.
> 
> Is swap mounted :)?
> -Garrett

When I said 29 I was taking into account mounted swap partition which would make 30.

Murlin