Re: [LTP] [ANNOUNCEMENT]: Intermediate release for FEB'10

[Subrata M. <su...@li...>]

Garrett Cooper wrote:
> On Mon, Feb 22, 2010 at 8:49 AM, Rishikesh K Rajak
> <ris...@li...> wrote:
>   
>> Hi Iranna,
>>
>>
>> Thanks for reporting this build failure and helping, as it will
>> really help to make ltp more stable.
>>
>> Here is the quick patch i am attaching which solves the problem.
>>
>> Signed-off By: Rishikesh K Rajak<ris...@li...>
>> Tested By: Rishikesh K Rajak<ris...@li...>
>> ---
>> diff --git a/testcases/kernel/syscalls/mbind/mbind01.c
>> b/testcases/kernel/syscalls/mbind/mbind01.c
>> index 5d7eb69..847186a 100644
>> --- a/testcases/kernel/syscalls/mbind/mbind01.c
>> +++ b/testcases/kernel/syscalls/mbind/mbind01.c
>> @@ -74,6 +74,7 @@ int  TST_TOTAL = 2;           /* total number of tests
>> in this file.   */
>>  #include <unistd.h>
>>  #include "include_j_h.h"
>>  #include "numa_helpers.h"
>> +#include <linux/mempolicy.h>
>>     
And also, including <linux/*.h> in any application(s) other than the 
kernel itself is better avoided.

Regards--
Subrata
>>  #if ! defined(LIBNUMA_API_VERSION) || LIBNUMA_API_VERSION < 2
>>     
>
> No. This patch shouldn't be committed because of namespace collisions
> between numa and mempolicy (thank the developers for just copy-pasting
> constants, macros, etc instead of properly requiring numa on the
> target system in order for mempolicy to work...).
>
> Thanks,
> -Garrett
>
> ------------------------------------------------------------------------------
> Download Intel&#174; Parallel Studio Eval
> Try the new software tools for yourself. Speed compiling, find bugs
> proactively, and fine-tune applications for parallel performance.
> See why Intel Parallel Studio got high marks during beta.
> http://p.sf.net/sfu/intel-sw-dev
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>