|
From: Shi W. <sh...@cn...> - 2010-02-22 08:29:11
|
at 2010-2-18 11:57, Rishikesh K Rajak wrote: > On Wed, Feb 17, 2010 at 09:08:39AM -0800, Garrett Cooper wrote: >> On Wed, Feb 17, 2010 at 12:09 AM, Rishikesh <ris...@li...> wrote: >>> Hi Shi, >>> >>> Thanks for your patch . It will be merged in feb 2010 release. >>> >>> Acked-By: Rishikesh K Rajak <ris...@li...> >>> >>> http://marc.info/?l=ltp-list&m=126440546415559&w=2 >> >> There's a lot of noise in the patch because of if-else behavior in >> trying to determine the mail app. That's why I didn't commit this (it >> requires verification of previous mail applications as well). > > Thanks Garret, Still i have not committed this to CVS repo. > > Shi, can you please verify if this patch does not break with any other > mail application. In fact, i don't know any other mail application. When i tested RHEL's alpha version, this ltp bug catched. so tried to fix it. Maybe, you should knock FOSS community(?). > > Thanks for your support. > -Rishi >> >> The mail test should be resistant to changes like these as a lot of >> developers in the FOSS community have different opinions on how to do >> things and don't follow any particular standard. This `heirloom mailx' >> support is just one said example that needs to be fixed. >> >> Thanks, >> -Garrett > > -- Shi Weihua |