From: Serge E. H. <se...@us...> - 2010-01-13 22:00:47
|
Quoting Stephen Smalley (sd...@ty...): > On Wed, 2010-01-13 at 11:37 -0800, Garrett Cooper wrote: > > Yeah, you're right. I was trying to beat around this bush by not > > copying these over, but it's better to have the test running and be > > improperly designed than it is for regressions to leak by today, until > > the day comes where these items are fixed. > > > > 1. So, Makefile is now copied over by default. > > 2. load is no longer done as part of all / install (test_selinux.sh > > was performing that function). > > > > So once the tests have been written to make and install independent of > > selinux-devel, etc... we'll be in good shape and I will switch these > > back to all / install dependent targets. I was trying to do it that > > way to avoid requiring make on the target under test, but I need to > > better understand the subject matter under test before we get to that > > point. > > Unfortunately, as the Makefile now includes other .mk files and those > are not copied over, it still doesn't work. > > Makefile:25: ../../../../../include/mk/env_pre.mk: No such file or directory > make: ../../../../../scripts/detect_distro.sh: Command not found > Makefile:90: ../../../../../include/mk/generic_leaf_target.mk: No such file or directory > make: *** No rule to make target `../../../../../include/mk/generic_leaf_target.mk'. Stop. > Failed to build and load test_policy module, aborting test run. > /etc/selinux /opt/ltp/testcases/kernel/security/selinux-testsuite/refpolicy > /opt/ltp/testcases/kernel/security/selinux-testsuite/refpolicy > > I suppose you could perform the make load as part of all/install > (preferably install as we really shouldn't need to be root to run make > all - although that no longer seems to be the case for the main ltp > either), and drop it from test_selinux.sh. But then they will need to > know/remember to remove the test policy when finished testing. But really the compile stage should just create test_policy.pp, which the testsuite can load and unload, right? -serge |