Re: [LTP] [PATCH] replacing -Wextra with -W

[Garrett C. <yan...@gm...>]

On Mon, Nov 9, 2009 at 2:24 AM, Cyril Hrubis <ch...@su...> wrote:
> Hi!
>> > >> > > Lately gcc developers introduced -Wextra flag that does the same as
>> > >> > > -W but is more descriptive. According to this using -W flag should
>> > >> > > be safe (as gcc is backward compatlible) but using -Wextra is
>> > >> > > limited to newer gcc releases.
>> > >> > >
>> > >> > > Attached patch replaces all -Wextra occurences with -W and thus
>> > >> > > fixes compliation failures with older gcc (mine was gcc-3.3.3 on
>> > >> > > sles).
>> > >> >
>> > >> > it'd be better if we had configure tests for -W flags, but that would
>> > >> > take a bit more effort, and i dont think it should preclude applying
>> > >> > your patch. however, please make this change first:
>> > >> >  - integrated Makefiles shouldnt be setting flags at all, so just
>> > >> > delete the whole line in
>> > >> > testcases/kernel/controllers/{cpuctl,cgroup}_fj/Makefile
>> > >>
>> > >> Patch that should be applied over the previous one attached.
>> > >
>> > > thanks, ive merged the two and added to the tree.  hopefully i didnt
>> > > screw anything up in the (simple) process ;).
>> >
>> >     It looks fine from my end :]. We should really restrict the -W*
>> > flag setting to include/mk/config.mk like you suggested though, so
>> > maybe we should clean up all of the Makefiles in one shot.
>>
>> some of the Makefiles Cyril highlighted havent been converted to the common
>> .mk framework.  we could cheat and just pull in config.mk fo some, but for
>> others (ones that build kernel modules), i'm not sure that will work.  linux'
>> kbuild gets pissy if you try to tweak build flags like CFLAGS/CPPFLAGS.  so we
>> might have to create a new .mk target specifically for kernel modules that
>> takes care of these details.
>
> In these I've only replaced -Wextra with -W. Is there any way this could broke them?

    Mike was actually referring specifically to integrating the kernel
modules testcases in the Makefile infrastructure. No worries -- just
side commentary :)..
Cheers!
-Garrett