[Ltp-cvs] ltp/testcases/network/lib6 Makefile,1.8,1.9

[Garrett C. <yab...@us...>]

Update of /cvsroot/ltp/ltp/testcases/network/lib6
In directory ddv4jf1.ch3.sourceforge.com:/tmp/cvs-serv5872/testcases/network/lib6

Modified Files:
	Makefile 
Log Message:
1. I screwed up and broke install by accident when I was monkeying around with env_post.mk.
2. Make in-build-tree testing a little more conducive as per Mike F's convincing argument:

requiring install-related variables to be sane in order to do `make install`
is fine (i.e. prefix/etc...).  but that is the only time install related
variables should be needed/consulted.

when you compile a package (i.e. run `make`) regardless of this being done at
the toplevel or a subdir only, the build process should never need anything
ltp related outside of the source tree (so i'm not talking about libcap or
whatever, just libltp).  this is the expected behavior for all packages out
there, not just ltp.

one reason for why this is a bad idea is that it is then impossible to
compile/test a new version of a package locally before installing it into the
live filesystem.  you would have to first uninstall the old version (rm -rf
/opt/ltp), then compile/install the new version, and then hope that (1) the
build is successful as well as (2) the package working as expected (bug free).
-mike

Signed-off-by: Garrett Cooper <yan...@gm...>



Index: Makefile
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/network/lib6/Makefile,v
retrieving revision 1.8
retrieving revision 1.9
diff -C2 -d -r1.8 -r1.9
*** Makefile	9 Oct 2009 17:56:05 -0000	1.8
--- Makefile	10 Oct 2009 23:53:29 -0000	1.9
***************
*** 22,45 ****
  ###########################################################################
  
! top_srcdir		?= ../../..
  
  include $(top_srcdir)/include/mk/testcases.mk
  
! CPPFLAGS		+= -D_GNU_SOURCE
! LDLIBS			+= -lpthread
! 
! LIB			:= $(DESTDIR)/$(libdir)/libruncc.a
! 
! MAKE_TARGETS		:= $(patsubst $(abs_srcdir)/%.c,%,$(filter-out %/runcc.c,$(wildcard $(abs_srcdir)/*.c)))
! 
! $(MAKE_TARGETS): | $(LIB)
  
! $(MAKE_TARGETS): LDLIBS	+= -lruncc
  
! $(LIB): $(builddir)/runcc.o
! 	$(AR) cr "$@" $^
! 	$(RANLIB) "$@"
  
! CLEAN_TARGETS		+= $(LIB)
  
  include $(top_srcdir)/include/mk/generic_leaf_target.mk
--- 22,38 ----
  ###########################################################################
  
! top_srcdir			?= ../../..
  
  include $(top_srcdir)/include/mk/testcases.mk
  
! CPPFLAGS			+= -D_GNU_SOURCE
  
! LDLIBS				+= -lpthread
  
! CLEAN_TARGETS			+= $(LIB)
  
! FILTER_OUT_MAKE_TARGETS		:= runcc
  
  include $(top_srcdir)/include/mk/generic_leaf_target.mk
+ 
+ $(MAKE_TARGETS): %: %.o runcc.o