From: Garrett C. <yan...@gm...> - 2009-10-10 22:30:24
|
On Sat, Oct 10, 2009 at 3:02 PM, Garrett Cooper <yan...@gm...> wrote: > On Sat, Oct 10, 2009 at 12:51 PM, Mike Frysinger <va...@ge...> wrote: >> On Friday 09 October 2009 13:48:42 Garrett Cooper wrote: >>> I'm posting the following diff as reference (it's compressed >>> because the entire diff is ~1.8MB) as I'm now going to commit the >>> following to CVS after 1.25 years of anticipation waiting for this >>> enhancement in the Makefiles to correct issues related to difficulty >>> primarily in 1) terms of maintenance, 2) lack of out-of-build-tree >>> support, and 3) the fact that we weren't following autoconf-like >>> practices for installation [ties into 1) and 2)]. >>> If there are any issues in building the sourcebase after this, >>> please consult the TODO file in the root directory to determine >>> whether or not it's a known issue. If the issue isn't listed there, >>> please email the list and CC me. I ran it on Fedora 10, Gentoo Linux, >>> and Ubuntu Feisty Fawn, so I tried to get as much coverage as possible >>> when making these changes. >> >> seems like the compile step depends on install dirs. a simple make in a >> subdir fails with: >> $ make >> mkdir -p "/opt/ltp/testcases/bin" >> mkdir: cannot create directory `/opt/ltp': Permission denied >> make: *** [/opt/ltp/testcases/bin] Error 1 >> >> or if prefix isnt set: >> $ make >> mkdir -p "/testcases/bin" >> mkdir: cannot create directory `/testcases': Permission denied >> make: *** [/testcases/bin] Error 1 > > Both of these items requires the appropriate prefix to be put in > config.mk, and/or the definition of DESTDIR, because the new Makefile > infra installs directly to the destination folder. > I'll go and fix the latter case though... I just changed it so it won't do this anymore, but what I need to know exactly is how do you intend to do submakes, e.g. do you intend to manually compile the library, NOT do the install, then go to a subdir, run make all, and that's it? make install (IMO) still needs $(prefix) to be defined to a sane setting, so it's now only a requirement for install. Thanks, -Garrett |