Re: [LTP] [RFC] Bourne shell command library

[Mike F. <va...@ge...>]

On Monday 03 August 2009 02:32:59 Garrett Cooper wrote:
> export SHELL_DEBUG=${SHELL_DEBUG:=0}

does this really need to be exported ?  otherwise, the simpler way to write a 
default value is:
: ${SHELL_DEBUG:=0}

there are a bunch of places this can be fixed in this file

> exists()
> {
>     for cmd in $@; do

you should always use "$@", not $@.  if you actually want $@, then you should 
use $* to keep things clear.

>         if ! which $cmd 2>&1 1>/dev/null; then

which is not portable.  use `type` or `command`.  $cmd should be quoted.

>     TCID=${TCID:=}
>     [ -z "$TCID" ] && TCID=${0##*/}

does this really need to be two lines ?
-mike