[Ltp-cvs] ltp/testcases/kernel/syscalls/clone clone01.c,1.13,1.14

[Subrata <sub...@us...>]

Update of /cvsroot/ltp/ltp/testcases/kernel/syscalls/clone
In directory ddv4jf1.ch3.sourceforge.com:/tmp/cvs-serv18973/ltp/testcases/kernel/syscalls/clone

Modified Files:
	clone01.c 
Log Message:
clone01 -c 10 on x86: Michal Simek <mic...@pe...> reported: can you please to run clone01 syscall test on any x86 machine? I am getting fault there when I run it 10 times for example. The same problem I have on Microblaze.
$> ./clone01  -c 10
clone01     1  TPASS  :  clone() returned 22738
clone01     1  TPASS  :  clone() returned 22740
clone01     1  TPASS  :  clone() returned 22742
clone01     1  TPASS  :  clone() returned 22748
clone01     1  TPASS  :  clone() returned 22750
clone01     1  TPASS  :  clone() returned 22752
clone01     1  TPASS  :  clone() returned 22754
clone01     1  TFAIL  :  clone() returned 134919589, errno = 22755
clone01     1  TPASS  :  clone() returned 22744
clone01     1  TPASS  :  clone() returned 22746,
"Serge E. Hallyn" <se...@us...> replied: All right I don't have the patiente to wade through the parse_opts and usc_lib crap, but this is not a clone failure.  What appears to be happening is setup() at the top of clone01.c is calling lib/parse_opts.c:usc_global_setup_hook(), with STD_COPIES set to the count option you passed in.  That forks of 10 copies of the test. I don't know what happens with the actual loop then, but the reason you get the error for the last clone test is that one of those forked copies of clone01 (*not* one of the cloned children) exits, and wait() catches that one.  That is why wait() returned 22744, which isn't any of the cloned children. So one stupid way of fixing this without dealing with the convoluted setup junk would be to change the waitpid chunk of the code like so.


Index: clone01.c
===================================================================
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/clone/clone01.c,v
retrieving revision 1.13
retrieving revision 1.14
diff -C2 -d -r1.13 -r1.14
*** clone01.c	23 Mar 2009 13:35:39 -0000	1.13
--- clone01.c	4 Aug 2009 11:08:10 -0000	1.14
***************
*** 131,134 ****
--- 131,135 ----
  #endif
  
+ again:
  		if ((child_pid = wait(&status)) == -1) {
  			tst_brkm(TBROK, cleanup, "wait() failed; error no ="
***************
*** 139,147 ****
  		if (TEST_RETURN == child_pid) {
  			tst_resm(TPASS, "clone() returned %d", TEST_RETURN);
! 		} else {
! 			tst_resm(TFAIL, "clone() returned %d, errno = %d ",
! 				 "wait() returned %d", TEST_RETURN, TEST_ERRNO,
  				 child_pid);
! 		}
  
  	}			/* End for TEST_LOOPING */
--- 140,148 ----
  		if (TEST_RETURN == child_pid) {
  			tst_resm(TPASS, "clone() returned %d", TEST_RETURN);
! 		} else if (TEST_RETURN == -1) {
! 			tst_resm(TFAIL, "clone() returned %d, errno = %d wait() returned %d\n", TEST_RETURN, TEST_ERRNO,
  				 child_pid);
! 		} else
! 			goto again;
  
  	}			/* End for TEST_LOOPING */