Re: [LTP] [PATCH 3/4] Make system enhancements, Draft 3

[Subrata M. <su...@li...>]

On Tue, 2009-07-21 at 16:01 +0200, Michal Simek wrote: 
> Garrett Cooper wrote:
> > On Tue, Jul 21, 2009 at 6:01 AM, Michal Simek<mic...@pe...> wrote:
> >   
> >> Garrett Cooper wrote:
> >>     
> >>> On Sun, Jul 19, 2009 at 10:25 PM, Michal
> >>> Simek<mic...@pe...> wrote:
> >>>       
> >>>>> +LIBOBJS                              := $$(addprefix $$(builddir)/,$$(patsubst %.c,%.o,$$(LIBSRCS)))
> >>>>>
> >>>>>
> >>>>>           
> >>>> long line.
> >>>>
> >>>>         
> >>> I try my best to do two things with makefile code:
> >>> 1. align Makefile code with single tab, then spaces.
> >>> 2. compress as many statements as possible to reduce the number of
> >>> required evaluation steps, because that can result in interesting
> >>> behavior from make with define blocks...
> >>>
> >>> I will try and compress the space further (that line was tab
> >>> separated) in a style cleanup commit after this is all said and
> >>> committed, if I don't get to it sooner. It's just easier to add and
> >>> delete tabs for now :).
> >>>
> >>>       
> >> make no sense to send a patch with coding style violation and then send
> >> next patch
> >> which fixed that bad coding style. It is better to do it properly in
> >> first time.
> >> We have to clean whole LTP source code not pollute it.
> >>     
> >
> > I am cleaning up a lot more `style-guide violations' than I am causing in LTP.
> >
> > All Cisco level project support for LTP has been yanked recently due
> > to limited restructuring (the other gentleman that was going to help
> > me is no longer part of my project as well), so I'm doing this solely
> > on my spare time.
> >
> > If you _want_ to fix the items, you can too -- this is an opensource
> > project you know ;)... I am aware of the eyesores and I'll get to them
> > as soon as I can.
> >
> > 1. If it breaks functionality, it needs to be fixed before commit.
> > 2. If it's an eyesore, I'll prioritize it and fix it ASAP.
> >
> > BTW, AFAIK there isn't a style guide for LTP -- so before correcting
> > me on style I'd produce a writeup stating that _this_ is how I need to
> > code my code in order to meet LTP's standards, please.
> >   
> We talked about coding style for LTP some month ago. LTP should follow
> linux kernel coding style. I though that Subrata wrote it somewhere,
> didn't you?

Yes, we decided on that and even talked about checkpatch.pl from kernel
sources to verify our patches as well. I do not know if i have recorded
it somewhere. Yes, let me fix up the documentation as well, which i will
probably do with tomorrowś release.

Regards--
Subrata

> On the base on it I fixed a lot of syscalls tests in my spare time too.
> 
> Michal
> 
> > Thanks,
> > -Garrett
> >   
> 
>