Re: [LTP] [PATCH] Re::personality test case build fails

[Subrata M. <su...@li...>]

On Thu, 2009-06-25 at 17:04 +0530, Subrata Modak wrote: 
> Hi Pradeep,
> 
> >On Tue, 2009-06-23 at 18:39 +0530, Pradeep K Surisetty wrote:
> >Here is the list of platforms on which "personality test case" fails.
> > 
> > Platforms:
> > e326,x366
> > 
> > kernel:
> > 2.6.16.60-0.46.6-smp
> > 
> > Build Failure:
> > 
> > cc -I../../../../include -Wall    personality01.c  -L../../../../lib -lltp
> > -o personality01
> > /tmp/cc2aVCsG.o: In function `main':
> > personality01.c:(.text+0x58): undefined reference to `personality'
> > personality01.c:(.text+0xb6): undefined reference to `personality'
> > personality01.c:(.text+0x1a5): undefined reference to `personality'
> > collect2: ld returned 1 exit status
> > make: *** [personality01] Error 1
> > 
> > Subrata,
> > Can you point me, if any work around exists for this.
> 
> The following patch will probably fix the issue on your system. Please
> test this patch and let me know.
> 
> Signed-off-by: Subrata Modak <su...@li...>,

I checked in this.

Regards--
Subrata

> ---
> 
> --- ltp-intermediate-20090622/testcases/kernel/syscalls/personality/personality01.c.orig	2009-06-25 16:45:55.000000000 +0530
> +++ ltp-intermediate-20090622/testcases/kernel/syscalls/personality/personality01.c	2009-06-25 16:59:15.000000000 +0530
> @@ -58,7 +58,7 @@
>  #include "usctest.h"
> 
>  #include <errno.h>
> -#include <linux/personality.h>
> +#include <sys/personality.h>
>  #undef personality
> 
>  extern int personality(unsigned long);
> @@ -75,6 +75,7 @@ int pers[] = { PER_LINUX, PER_LINUX_32BI
>  	PER_IRIX32, PER_IRIXN32, PER_IRIX64
>  };
> 
> +#ifdef __NR_personality
>  int main(int ac, char **av)
>  {
>  	int lc;			/* loop counter */
> @@ -146,6 +147,13 @@ int main(int ac, char **av)
> 
>  	 /*NOTREACHED*/ return 0;
>  }
> +#else
> +int main(int ac, char **av)
> +{
> +	tst_resm(TCONF, "personality() not defined in your system");
> +	tst_exit();
> +}
> +#endif
> 
>  /*
>   * setup() - performs all the ONE TIME setup for this test.
> --- ltp-intermediate-20090622/testcases/kernel/syscalls/personality/personality02.c.orig	2009-06-25 16:46:02.000000000 +0530
> +++ ltp-intermediate-20090622/testcases/kernel/syscalls/personality/personality02.c	2009-06-25 16:59:25.000000000 +0530
> @@ -79,6 +79,7 @@ extern int Tst_count;
> 
>  #define	PER_BAD	0x00dd		/* A non-existent personality type */
> 
> +#ifdef __NR_personality
>  int main(int ac, char **av)
>  {
>  	int lc;			/* loop counter */
> @@ -128,6 +129,14 @@ int main(int ac, char **av)
> 
>  	 /*NOTREACHED*/ return 0;
>  }
> +#else
> +int main(int ac, char **av)
> +{
> +	tst_resm(TCONF, "personality() not defined in your system");
> +	tst_exit();
> +}
> +#endif
> +
> 
>  /*
>   * setup() - performs all the ONE TIME setup for this test.
> 
> ---
> Regards--
> Subrata
> 
> > 
> > -Pradeep
> > 
> >