Re: [LTP] cpusets: document adding/removing cpus to cpuset elaborately

[Subrata M. <tos...@gm...>]

On Tue, Jun 16, 2009 at 4:46 PM, Nikanth Karthikesan <kni...@su...>wrote:

> Writing a pid to the file, tasks adds that task to that cgroup/cpuset. But
> to
> add a cpu/mem to a cpuset, the new list of cpus should be written to the
> cpuset.mems file which would replace the old list of cpus. Make this
> clearer
> in the documentation.
>
> Signed-off-by: Nikanth Karthikesan <kni...@su...>


Hey,

Great to see that you are working on the documentation part. Have you given
a try to test the CPUSET features in the kernel with the recently added
tests from LTP(
http://ltp.cvs.sourceforge.net/viewvc/ltp/ltp/testcases/kernel/controllers/cpuset/)
? It would be great if you help us in improving them further.

Regards--
Subrata


>
> ---
>
> diff --git a/Documentation/cgroups/cpusets.txt
> b/Documentation/cgroups/cpusets.txt
> index f9ca389..1d7e978 100644
> --- a/Documentation/cgroups/cpusets.txt
> +++ b/Documentation/cgroups/cpusets.txt
> @@ -777,6 +777,18 @@ in cpuset directories:
>  # /bin/echo 1-4 > cpus         -> set cpus list to cpus 1,2,3,4
>  # /bin/echo 1,2,3,4 > cpus     -> set cpus list to cpus 1,2,3,4
>
> +To add a CPU to a cpuset, write the new list of CPUs including the
> +CPU to be added. To add 6 to the above cpuset:
> +
> +# /bin/echo 1-4,6 > cpus       -> set cpus list to cpus 1,2,3,4,6
> +
> +Similarly to remove a CPU from a cpuset, write the new list of CPUs
> +without the CPU to be removed.
> +
> +To remove all the CPUs:
> +
> +# /bin/echo "" > cpus          -> clear cpus list
> +
>  2.3 Setting flags
>  -----------------
>
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to maj...@vg...
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Regards & Thanks--
Subrata