From: Subrata <sub...@us...> - 2009-03-30 08:20:02
|
Update of /cvsroot/ltp/ltp/testcases/network/multicast/mc_cmds In directory ddv4jf1.ch3.sourceforge.com:/tmp/cvs-serv18974/ltp/testcases/network/multicast/mc_cmds Modified Files: mc_cmds Log Message: It has come to our attention that when running multicast tests that the multicast ping test assumes that all the machines on the network, including the machine getting tested, have multicast ping enabled. This has not been the case since 2005 when multicast ping was disabled by default, mostly to inhibit ddos activity. See this conversation for more details: https://bugzilla.redhat.com/show_bug.cgi?id=159367. Now on all kernels, /proc/sys/net/icmp_echo_ignore_broadcasts is set to 1 by default, thereby failing this test. But the error message is wrong. Multicast is not disabled, only multicast ping. This patch modifies the error message and tells that it is now normal to fail.Signed-off-by: Vernon Mauery <ve...@us...>, Acked-by: Sripathi Kodi <sri...@in...>. Index: mc_cmds =================================================================== RCS file: /cvsroot/ltp/ltp/testcases/network/multicast/mc_cmds/mc_cmds,v retrieving revision 1.14 retrieving revision 1.15 diff -C2 -d -r1.14 -r1.15 *** mc_cmds 21 Oct 2008 08:56:23 -0000 1.14 --- mc_cmds 30 Mar 2009 08:19:51 -0000 1.15 *************** *** 128,133 **** if [ $? -eq 0 ] then ! echo "Multicast disabled on this system" ! exit fi --- 128,132 ---- if [ $? -eq 0 ] then ! end_testcase "Multicast ping disabled on this system (this is normal on post 2005 kernels)" fi |