Re: [LTP] [PATCH] cleanup user space device-driver Makefiles

[Subrata M. <su...@li...>]

On Fri, 2009-03-20 at 07:35 +0100, Németh Márton wrote:
> Subrata Modak wrote:
> > On Wed, 2009-03-04 at 17:37 +0100, Németh Márton wrote:
> >> Cleanup the Makefiles for the user space part of the device-driver tests.
> >> Add "make clean".
> >>
> >> Signed-off-by: Márton Németh <nm...@fr...>
> > 
> > Thanks. But, i think you need to resend this:
> > 
> > patching file testcases/kernel/device-drivers/agp/user_space/Makefile
> > Hunk #1 FAILED at 1.
> > 1 out of 1 hunk FAILED -- saving rejects to file
> > testcases/kernel/device-drivers/agp/user_space/Makefile.rej
> > patching file testcases/kernel/device-drivers/base/user_base/Makefile
> > Hunk #1 FAILED at 1.
> > 1 out of 1 hunk FAILED -- saving rejects to file
> > testcases/kernel/device-drivers/base/user_base/Makefile.rej
> > patching file
> > testcases/kernel/device-drivers/dev_sim_framework/user_space/Makefile
> > patching file testcases/kernel/device-drivers/pci/user_tpci/Makefile
> > Hunk #1 FAILED at 1.
> > 1 out of 1 hunk FAILED -- saving rejects to file
> > testcases/kernel/device-drivers/pci/user_tpci/Makefile.rej
> > patching file testcases/kernel/device-drivers/tbio/user_space/Makefile
> > patching file testcases/kernel/device-drivers/usb/user_usb/Makefile
> > Hunk #1 FAILED at 1.
> > 1 out of 1 hunk FAILED -- saving rejects to file
> > testcases/kernel/device-drivers/usb/user_usb/Makefile.rej
> 
> I don't understand why it fails for you it was working for me:
> 
> nmarci@machine:/usr/src/ltp$ patch -p0 <../cleanup_device_driver_makefiles2.patch
> patching file testcases/kernel/device-drivers/agp/user_space/Makefile
> patching file testcases/kernel/device-drivers/base/user_base/Makefile
> patching file testcases/kernel/device-drivers/dev_sim_framework/user_space/Makefile
> patching file testcases/kernel/device-drivers/pci/user_tpci/Makefile
> patching file testcases/kernel/device-drivers/tbio/user_space/Makefile
> patching file testcases/kernel/device-drivers/usb/user_usb/Makefile
> $
> 
> Nevertheless, please find attached the same patch created with "diff" instead
> of "cvs diff". I hope this will cleanly apply at your side, too.

Applied Cleanly. Thanks.

Regards--
Subrata

> 
> Regards,
> 
> 	Márton Németh
>