Re: [LTP] ARCH depended compilation

[Mike F. <va...@ge...>]

On Monday 02 March 2009 07:56:19 Michal Simek wrote:
> I think that is the right time to start with arch dependent compilation.
> Here is the patch which solve my problem with hyperthreading compilation.
>
> Mike: Any comments? If not I'll prepare proper patch for Subrata.
>
> --- a/Makefile
> +++ b/Makefile
> +ifndef ARCH
> +ARCH=i386
> +endif

this is no good imo.  the ARCH should either be discovered automatically, or 
not at all.

> --- a/testcases/kernel/sched/Makefile
> +++ b/testcases/kernel/sched/Makefile
> +ifeq ($(ARCH),i386)
> +SUBDIRS += hyperthreading
> +endif

i thought the code already had #ifdef's in it you could fix up easily ?
-mike