Re: [LTP] [PATCH] Make ltp compilable without libaio

[Subrata M. <su...@li...>]

On Mon, 2009-01-26 at 11:24 +0100, Jiří Paleček wrote:
> On Mon, 26 Jan 2009 11:08:41 +0100, Garrett Cooper <yan...@gm...>  
> wrote:
> 
> > On Sun, Jan 25, 2009 at 1:43 PM, Jiri Palecek <jpa...@we...> wrote:
> >> Hello,
> >>
> >> This is a patch inspired by numerous whining recently seen on ltp-list
> >> concerning compile failures when libaio is not present.
> >>
> >> This includes changes:
> >>
> >>  - add stubs to the aio tests
> >>  - remove -laio from doio and pipeio makefile, as it was superfluous
> >
> >>  #define _XOPEN_SOURCE 600
> >
> > Wrong -- use GNU_SOURCE or something along those lines...
> 
> As you can see, this is a context line of the patch. That means it wasn't  
> changed and, bearing no connection to the patch, it wasn't event meant to  
> changed, even if I thought it needed to be fixed.
> 
> >> +#else
> >> +int main()
> >
> > Where's the corresponding #if or #ifdef ?
> 
> Right at the beginning, #ifdef HAVE_LIBAIO_H
> 
> >> +int main()
> >
> > Please use int main(void) here to avoid complaints from SA tools.
> 
> OK, shall I resend?

Yes, Can you please ?

Regards--
Subrata

> 
> Regards
>      Jiri Palecek
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by:
> SourcForge Community
> SourceForge wants to tell your story.
> http://p.sf.net/sfu/sf-spreadtheword
> _______________________________________________
> Ltp-list mailing list
> Ltp...@li...
> https://lists.sourceforge.net/lists/listinfo/ltp-list