Re: [LTP] [patch 1/4] Dont mix-up the use of DESTDIR and PREFIX.

[Subrata M. <su...@li...>]

On Fri, 2008-10-17 at 13:28 +0200, Daniel Gollub wrote:
> Hi Subrata,
> 
> On Friday 17 October 2008 12:34:14 Subrata Modak wrote:
> > Hi Daniel,
> >
> > On Thu, 2008-10-16 at 23:07 +0200, Daniel Gollub wrote:
> > > plain text document attachment (buildenv-destdir.patch)
> > > Introduced PREFIX and LIBSUFFIX variables.
> > >
> > > DESTDIR is often used within packaging scripts/spec files. Use PREFIX
> > > variable instead to manipulate the installation destination directory.
> > >
> > > Introduced LIBSUFFIX to allow to manipulate library directory to lib64
> > > e.g. for distribution packaging for x86_64 or others architectures.
> > >
> > > Signed-off-by: Daniel Gollub <dg...@su...>

Merged.

Regards--
Subrata

> > >
> > > ---
> > >  doc/man1/Makefile |    4 ++--
> > >  doc/man3/Makefile |    4 ++--
> > >  include/Makefile  |    4 ++--
> > >  lib/Makefile      |    6 +++---
> > >  pan/Makefile      |    8 ++++----
> > >  5 files changed, 13 insertions(+), 13 deletions(-)
> > >
> > > Index: ltp-full-20080825/pan/Makefile
> > > ===================================================================
> > > --- ltp-full-20080825.orig/pan/Makefile
> > > +++ ltp-full-20080825/pan/Makefile
> > > @@ -2,7 +2,7 @@
> > >  LOADLIBES += -lm
> > >  LFLAGS += -l
> > >  CFLAGS += -w
> > > -DESTDIR = /opt/ltp
> > > +PREFIX = /opt/ltp
> > >
> > >  all: pan bump scanner
> > >
> > > @@ -16,9 +16,9 @@ scanner: scan.o scanner.o reporter.o tag
> > >
> > >
> > >  install: pan bump scanner
> > > -     install -D scanner $(DESTDIR)/bin/scanner
> > > -     install -D pan $(DESTDIR)/bin/pan
> > > -     install -D bump $(DESTDIR)/bin/bump
> > > +     install -D scanner $(DESTDIR)/$(PREFIX)/bin/scanner
> > > +     install -D pan $(DESTDIR)/$(PREFIX)/bin/pan
> > > +     install -D bump $(DESTDIR)/$(PREFIX)/bin/bump
> >
> > Should the above not be:
> >
> > +       install -D scanner $(PREFIX)/bin/scanner
> > +       install -D pan $(PREFIX)/bin/pan
> > +       install -D bump $(PREFIX)/bin/bump
> 
> Actually not - the $(DESTDIR) was placed there on purpose. Packagers use often 
> the DESTDIR variable when building inside build environments/build systems. By 
> default DESTDIR don't get set at all in the Makefile - this means not setting 
> DESTDIR will allow regular/normal installation like today directly into the 
> specified PREFIX.
> 
> Setting DESTDIR allows you to install the build inside a temporary directory - 
> which is sometimes required when building inside  some build systems.
> 
> I just found this document - this gives a more detailed/clearer explanation:
> http://www.gnu.org/prep/standards/html_node/DESTDIR.html
> 
> best regards,
> Daniel