Re: [LTP] [PATCH 3/4] Fix run.sh

[Darren H. <dv...@us...>]

On Wed, 2008-09-17 at 13:41 +0530, Chirag Jog wrote:
> * Darren Hart <dv...@us...> [2008-09-16 15:27:10]:
> 
>  This patch fixes a few minor issues in run.sh
> 
>  1. Adds list option to the usage() command.
>  2. Remove java from "all" tests to be run.
>  3. It fix the output of usage (./run.sh or ./run.sh -h)
> 
>  Tested: Running "./run.sh -t func", "./run.sh -t all" , "./run.sh",
>  "./run.sh -h"
> 
> 
>  Signed-Off-By: Chirag <ch...@li...>
> 
> 
> 
> diff --git a/testcases/realtime/config.mk b/testcases/realtime/config.mk
> index 083db58..19ccddc 100644
> --- a/testcases/realtime/config.mk
> +++ b/testcases/realtime/config.mk
> @@ -23,4 +23,3 @@ LDLIBS   += $(srcdir)/lib/libjvmsim.o \
>  	   $(srcdir)/lib/libstats.o \
>  	   -lpthread -lrt -lm
> 
> -CFLAGS   += -m64
> diff --git a/testcases/realtime/run.sh b/testcases/realtime/run.sh
> index ce0070d..f1e03ad 100755
> --- a/testcases/realtime/run.sh
> +++ b/testcases/realtime/run.sh
> @@ -32,17 +32,17 @@
> 
>  function usage()
>  {
> -	echo -e "\nUsage: run.sh [-p profile] -t test-argument [-l loop num_of_iterations] [-t test-argument1 [-l loop ...]] ..."
> -	echo -e "\nWhere test-argument = func | stress | perf | all | list | clean | test_name "
> -	echo -e "\n and: \n"
> -	echo -e " func = 	all functional tests will be run "
> -	echo -e " stress = 	all stress tests will be run "
> -	echo -e " perf = 	all perf tests will be run "
> -	echo -e " all =		all tests will be run "
> -	echo -e " clean = 	all logs deleted, make clean performed "
> -	echo -e " test_name = 	only test_name subdir will be run (e.g: func/pi-tests) "
> -	echo -e " -p profile = 	use profile instead of default "
> -	echo -e " -h	    =	help"
> +	echo -e "\nUsage: run.sh [-p profile] -t test-argument [-l num_of_loops]"
> +	echo -e "\n-t test-arguments   Where test-argument can be a space separated sequence of: "
> +	echo -e " \t\t\tfunc		all functional tests will be run "
> +	echo -e " \t\t\tstress		all stress tests will be run "
> +	echo -e " \t\t\tperf		all perf tests will be run "
> +	echo -e " \t\t\t all		all tests will be run"

Appears to be an extra space here between the tabs and "all".  Is that
intentional?

> +	echo -e " \t\t\tlist		all available tests will be listed  "
> +	echo -e " \t\t\tclean		all logs deleted, make clean performed "
> +	echo -e " \t\t\ttest_name	only test_name subdir will be run (e.g: func/pi-tests) "
> +	echo -e " \t\t\t-p profile	use profile instead of default (see doc/AUTOMATED_RUN)"
> +	echo -e " \t\t\t-h		help"

I believe -p and -h should not have the 3 \t before them... we don't
want them to line up with the test-argument options do we?  In future
patches, can you porovide example output, so we don't have to parse the
echo statements?

--
Darren

>  	echo -e "\n"
>  	exit 1;
>  }
> @@ -134,7 +134,7 @@ find_test()
>  		;;
>  	all)
>  		# Run all tests which have run_auto.sh
> -		TESTLIST="func stress java perf"
> +		TESTLIST="func stress perf"
>  		;;
>  	list)
>  		# This will only display subdirs which have run_auto.sh
> 
-- 
Darren Hart
Real-Time Linux Team Lead
IBM Linux Technology Center