Re: [LTP] [patch 0/9] Network NS patch

[Subrata M. <su...@li...>]

Hi Veerendra,

On Thu, 2008-09-18 at 16:15 +0530, Veerendra wrote:
> Subrata Modak wrote:
> > Hi Benjamin,
> >
> > On Wed, 2008-09-17 at 15:45 +0200, Benjamin Thery wrote:
> >   
> >> Subrata Modak wrote:
> >>     
> >>> Hi Veerendra,
> >>>
> >>> Before i go ahead in applying and testing your patches, i would like to
> >>> point out something. Last week in our private discussion, we identified
> >>> one of the easiest ways to do NETNS testing. The simplest infrastructure
> >>> to test this will be using the existing LTP Network tests, and will
> >>> involve the following procedure:
> >>>
> >>> 1) Create your Parent Container on a Remote server, and, start all the
> >>> networking Daemon services that are required on a remote server in case
> >>> of normal LTP Network testing,
> >>> 2) Create multiple child containers in another host,
> >>> 3) Start the ltp/testscripts/networktests.sh from each of the child
> >>> container,
> >>> 4) Analyse the results after the tests are complete.
> >>>
> >>> With the above approach, we would have required just one script on the
> >>> child containers host machine, which would have:
> >>>
> >>> 1) Created the containers and all those stuff,
> >>> 2) Invoked the networktests.sh script from each of the child containers,
> >>> 3) Other House keeping stuff.
> >>>
> >>> I am not sure what other procedure you are employing to test NETNS. Is
> >>> the above procedure not simple to implement ?
> >>>       
> >> I also think this is how most of the testing for netns should be done:
> >> run the existing network tests in network namespaces to check there are 
> >> no regression. No need to rewrite all the network tests for the netns
> >> case.
> >>     
> >
> > Thanks for providing your inputs.
> >
> > Veerendra/Sudhir/Gowri,
> >
> > Can you please work on the points mentioned my Benjamin and come out
> > with a nenewed set of patches which addresses the following:
> >
> > 1) Use the existing network tests available in LTP for netns testing,
> > 2) Integrate additional netns testing, as veerendra might have written
> > additional tests (in his 0-9 series patches).
> >
> > Regards--
> > Subrata
> >
> >   
> >> But, we also need some additional test cases, for basic netns operations
> >> (creation, deletion, moving interface between namespaces) and specific
> >> features brought by netns. For example the sysfs tests sent by Veerendra
> >> to check what is seen in /sys/class/net from different namespaces, or
> >> the test that rename a network interface in a child netns with a name
> >> already in use in another namespace.
> >>
> >> Regards,
> >> Benjamin
> >>
> >>     
> Yes , we are trying to use the existing tests of LTP. And not re-writing 
> the same testcases of LTP.
> There may be few cases, where we cannot not use  existing LTP testcases.
> In these cases  we may re-write them for containers.
> 
> Most of the testcases submitted are to create the infra-structure to 
> create, delete containers .
> And I have started the sshd in the containers created.
> After commenting out the "cleanup" line in the script;  anybody can 
> login into the containers, and *run* other testcases.

Can you also provide me with the same .config file on the kernel that
you have run those tests as well as the test results of the same netns
run ?

Regards--
Subrata

> 
> Regards
> Veerendra C
> 
> 
> We can
> 
> For the same reason, if any
> 
> >>> Regards--
> >>> Subrata
> >>>
> >>> On Wed, 2008-09-10 at 18:40 +0530, Veerendra wrote:
> >>>       
> >>>> Submitting the series of patches  for network namespace of containers . 
> >>>> These patches addresses the comments of Benjamin/Serge on the patches I 
> >>>> had posted earlier. Also included the ack of Serge.
> >>>>
> >>>> Regards
> >>>> Veerendra C
> >>>>  
> >
> >   
>