From: Subrata M. <su...@li...> - 2008-08-22 21:46:09
|
On Sat, 2008-08-23 at 00:07 +0530, Vijay Kumar wrote: > Subrata Modak <su...@li...> wrote: > > make[4]: Entering directory > > `/root/subrata/ltp/ltp-intermediate-20080820/testcases/kernel/syscalls/move_pages' > > cc -Wall -I../../include -g -Wall -I../../../../include -Wall -c -o > > move_pages_support.o move_pages_support.c > > cc -Wall -I../../include -g -Wall -I../../../../include -Wall > > move_pages01.c move_pages_support.o -L../../../../lib -lltp -lnuma -lrt > > -o move_pages01 > > move_pages01.c: In function main: > > move_pages01.c:101: warning: implicit declaration of function > > numa_move_pages > > Hi Subrata, > as pointed out by Jin Bing Guo, only recent versions of libnuma have > support for move_pages(). It is necessary to check if move_pages() > support is available before compiling the test cases. > > Changelog: > > * Check if move_pages() support is available in libnuma. > > Signed-off-by: Vijay Kumar <vij...@br...> Yes, it solves the issue on 2.6.16.21-0.8-ppc64. Thanks for the patch. It is merged now. Regards-- Subrata > > testcases/kernel/syscalls/move_pages/Makefile | 19 ++++++++++++++++++- > 1 files changed, 18 insertions(+), 1 deletions(-) > > diff --git a/testcases/kernel/syscalls/move_pages/Makefile b/testcases/kernel/syscalls/move_pages/Makefile > index 77cdbd9..4f861ed 100644 > --- a/testcases/kernel/syscalls/move_pages/Makefile > +++ b/testcases/kernel/syscalls/move_pages/Makefile > @@ -19,12 +19,29 @@ > CFLAGS += -I../../../../include -Wall > LDLIBS += -L../../../../lib -lltp -lnuma -lrt > > -ifeq ($(HAS_NUMA),yes) > +check_numa_move_pages = $(shell \ > + if echo -e \ > + "\#include <numa.h>\n\ > + int main() \ > + { \ > + numa_move_pages(0, 0, NULL, NULL, NULL, 0); \ > + return 0; \ > + }" | $(CC) -xc -lnuma - > /dev/null 2>&1 ; \ > + then echo yes ; \ > + else echo no ; fi) > + > +HAS_NUMA_MOVE_PAGES := $(call check_numa_move_pages) > + > +ifeq ($(HAS_NUMA_MOVE_PAGES),yes) > SRCS = $(wildcard *.c) > TARGETS = $(patsubst %.c, %, $(wildcard *[0-9].c)) > endif > > all: $(TARGETS) > +ifeq ($(HAS_NUMA_MOVE_PAGES),no) > + @echo "Note: Libnuma with move_pages support is required for" \ > + "move_pages testcases."; > +endif > > move_pages_support.o: move_pages_support.h move_pages_support.c > |