From: Vijay K. <vij...@br...> - 2008-06-18 14:16:17
|
subrata> > There is a script in testcases/kernel/numa/test.sh that checks if numa subrata> > support is available. Do we replicate it over here? I guess the best subrata> > approach would be to test for NUMA support in the toplevel Makefile and subrata> > pass the result to all other Makefiles. subrata> subrata> Don´t you think this will unnecessarily need other Makefiles to handle subrata> NUMA code check, even if they do not need it ? If it is like that a top subrata> level Makefile checks for libnuma and exports it, and, only those subrata> Makefile which deals with NUMA checks for this export variable, then it subrata> should be fine. Let us know how you would like to do this. Hi Subrata, Yes, only the ones that need NUMA will check for it. BTW, there is one other problem in the patch. The third test case has to be run with root privileges. Currently this problem is being handled in two different ways in LTP test cases. 1. Install the program with set-uid bit set. 2. Check if the test case process has root privileges at run-time and if not break the test case. I guess the first approach is better. Do let me know your opinions about this. Regards, Vijay |