From: Gilles C. <Gil...@bu...> - 2008-05-21 13:18:12
|
Hello Ankita, Ankita Garg wrote: > I like the idea. It helps making testing infrastructure to be generic > and easy to extend. > > I might be missing something, or it could be that it is a TO-DO item, > but the patch looks incomplete...the testcases dont yet support the '-c' > option. Also, the parsers do not take the profiles into account. As I > said before, this could just be your first step towards completing the > entire infrastructure and you might have the rest in your To-Do.. Actually, the '-c' option is not mandatory for this patch to work since the profiles can take any command line. Arguments are not interpreted by the scripts which run the command lines as found in the profile. In a previous patch, I added that '-c' argument only to tests that feature pass/fail criteria. Some tests don't feature it. This is why you don't find this option everywhere. Does this answer your question? Which parser are you refering to? > Otherwise, the patch looks fine to me. Applied it and seems to be > working fine. Thanks for your feedback. Gilles. |