Re: [LTP] Why 2 libipc's?

[Subrata M. <su...@li...>]

On Tue, 2008-05-13 at 15:32 -0700, Garrett Cooper wrote:
> There's a libipc in ".../testcases/kernel/mem/hugetlb/lib/" and also
> one in ".../testcases/kernel/syscalls/ipc/lib". The source is
> (not-so-astoundingly) almost the same, with only a few extra macros
> with hugetlb's libipc and some extra code (not much) in getipckey(..);
> I'm not quite sure why hugetlb uses a time seeded random key lookup
> method whereas the source in ipc features the almost same exact
> functionality, moduland and all. get_used_msgqueues and
> get_max_msgqueues also exist only in ipc's libipc code.
> 
> Why isn't there just 1 libipc, with the non-commonalities stripped out
> of the source, or at least modularized to the extent where only one
> library is required?

I like this idea too. Modularize it to a bare common mimimum and submit
a patch whenever you are done with your most prioritized items first.
Make sure that it does not affect either HUGETLB or SYSCALLS/IPC runs
either independently or with default LTP run.

Regards--
Subrata

> 
> Thanks,
> -Garrett
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft 
> Defy all challenges. Microsoft(R) Visual Studio 2008. 
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> _______________________________________________ Ltp-list mailing list Ltp...@li... https://lists.sourceforge.net/lists/listinfo/ltp-list