Re: [LTP] [Fwd: Re: [PATCH] Several fixes to IDcheck.sh]

[Garrett C. <yan...@gm...>]

On Apr 27, 2008, at 6:37 PM, Mike Frysinger wrote:

> On Sunday 27 April 2008, Garrett Cooper wrote:
>> On Apr 27, 2008, at 4:37 PM, Mike Frysinger wrote:
>>> the patch didnt address some of the issues i raised, and after
>>> reading it line
>>> by line, i see that it actually introduces some bugs (probably due
>>> to copy &
>>> paste) as sometimes when "bin" should be used, "nobody" is used
>>> instead (and
>>> vice versa).
>>>
>>> i just rewrote the thing myself using Garrett's patch as a basis.
>>> please
>>> verify this works for you and i'll commit it.
>>
>> Thanks for catching my mistakes and modularizing it a bit more.
>>
>> Here's the final copy, with some nomenclature fixes in
>> "debug_vals" (logic wording was backwards which may confuse the end
>> user).
>
> i'm guessing the #! change was an accident.  otherwise i've  
> incorporated the
> re-order and committed.
> -mike

Ah, the shebang change was intentional but I forgot to remove it. /bin/ 
sh != /bin/bash on FreeBSD..
Thanks,
-Garrett