From: Sridhar V. <vin...@in...> - 2008-04-22 04:08:50
|
Renaud Lottiaux <Ren...@ke...> wrote on 04/21/2008 05:54:45 PM: > Le lundi 21 avril 2008, Sridhar Vinay a écrit : > > Renaud, > > > > Thanks for your suggestions. I've prepared a patch based on what you > > suggested. The genbessel.c file had to be modified to accommodate the > > tst_tmpdir() function. The resultant testcase code looks a bit untidy. > > Could you please review the patch and suggest any modifications if needed? > > > > (See attached file: bessel.patch) > > > > Also, if this patch is satisfactory, the same modifications could be done > > to the other float_* tests failing under concurrent executions. > > Is this patch really fixing the issue ? > Since you get the pwd before the tst_tmpdir(), the pwd will be the same > for all the tasks. So you will still create all the files in the same > directory. As each instance of float_bessel runs tst_tmpdir(), a different "/tmp/<dir>" is created for each instance and thus avoids parallel 'float_bessel's from accessing another instance's data files. I've run many concurrent instances of the testcase and they seem to run fine. > I guess you have to modify the main.c file to create the tmp dir and cd > into it. Somewhere at the begenning of the main() function. And don't > forget to remove the directory at the end, using the tst_rmdir() function. I guess I just have to add the tst_rmdir() function now. I will update and post the patch shortly. Regards, Vinay -------------------------------- Vinay Sridhar, Linux Technology Centre, India Systems & Technology Labs, Bangalore, India -------------------------------- |