From: Ricardo S. de A. <rsa...@li...> - 2007-09-15 01:02:05
|
Hi Subrata, I took a look at the merged code and found that we could simplify and remove the duplicated code there. I made this patch to remove the duplicated code, please review and say what do you think about it. I think that with this patch is much easier to read and understand the code :) Thanks, Ricardo Salveti On Friday 14 September 2007 07:10:45 Subrata Modak wrote: >I have merged this patch. >--Subrata-- > >On Tue, 2007-09-11 at 14:48 +0530, Subrata Modak wrote: >> Hi, >> I just observed that neither an Output file nor a Failed File is created >> by PAN if they are not mentioned as absolute path(s). But the logic for >> creation of LOG file exists either for an absolute path or under >> $LTPROOT/result directory. Moreover i think it is prudent to always >> create a Failed File for the user even if he/she explicitly did not >> mention it. >> >> Following Patch addresses: >> 1) Creation of Failed file under $LTPROOT/output directory, unless the >> path is specific >> 2) Creation of Output file under $LTPROOT/output directory, unless the >> path is specific >> 3) Compulsory Creation of Failed file, name depending on circumstances. >> >> Comments expected. >> >> --Regards-- >> Subrata -- Ricardo Salveti de Araujo |